Re: [ PATCH v2 3/3] ASoC: dt-bindings: Add support for Loongson audio card

[Yingkun Meng]

On 2023/6/13 16:36, Krzysztof Kozlowski wrote:
> On 12/06/2023 11:00, YingKun Meng wrote:
> > From: Yingkun Meng <mengyingkun@xxxxxxxxxxx>
> >
> > The audio card uses loongson I2S controller present in
> > 7axxx/2kxxx chips to transfer audio data.
> >
> > On loongson platform, the chip has only one I2S controller.
> >
> > Signed-off-by: Yingkun Meng <mengyingkun@xxxxxxxxxxx>
> > ---
> >   .../sound/loongson,ls-audio-card.yaml         | 70 +++++++++++++++++++
> >   1 file changed, 70 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> > new file mode 100644
> > index 000000000000..61e8babed402
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/loongson,ls-audio-card.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson 7axxx/2kxxx ASoC audio sound card driver
> > +
> > +maintainers:
> > +  - Yingkun Meng <mengyingkun@xxxxxxxxxxx>
> > +
> > +description:
> > +  The binding describes the sound card present in loongson
> > +  7axxx/2kxxx platform. The sound card is an ASoC component
> > +  which uses Loongson I2S controller to transfer the audio data.
> > +
> > +properties:
> > +  compatible:
> > +    const: loongson,ls-audio-card
> Generic compatible does not allow you to add any quirks or differences
> if one board is a bit different.

Yeah, i know. It's okay to use a generic compatible.

> Best regards,
> Krzysztof


Thanks,

Yingkun