Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

[Linus Walleij]

On Wed, Jun 14, 2023 at 10:44 AM Peter Vasil <petervasil@xxxxxxxxx> wrote:
> On Mon, May 8, 2023 at 11:21 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > +static struct gpiod_lookup_table nokia810_mmc_gpio_table = {
> > +       .dev_id = "mmci-omap",
> > +       .table = {
> > +               /* Slot index 1, VSD power, GPIO 23 */
> > +               GPIO_LOOKUP_IDX("gpio-16-31", 7,
> > +                               "vsd", 1, GPIO_ACTIVE_HIGH),
>
> Hello everyone,
> not sure if anyone noticed this already, or if I understand it
> wrong... shouldn't the "vsd" name in following lookup descriptor
> actually be "vio"?
>
> > +               /* Slot index 1, VIO power, GPIO 9 */
> > +               GPIO_LOOKUP_IDX("gpio-0-15", 9,
> > +                               "vsd", 1, GPIO_ACTIVE_HIGH),


Ooops. Copy/paste bug.

I'll send a fix.

Yours,
Linus Walleij