Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers

[John Garry]

On 12/06/2023 19:15, John Garry wrote:
> On 08/06/2023 10:44, Jing Zhang wrote:
> > > Unit is the format of the event_source device name. We should match 
> > > based on that as well as compat. I need to check the code again to 
> > > understand how that is done... it has changed a good bit in 3 years.
> > This situation only happens on uncore metric. I happened to write 
> > wrong Unit, but the metric still matches.
>
> I'm just double checking this now. I think any possible fix should be 
> easy enough for current code but may be tricky for backport with lots of 
> metric code changes.

I also have code to re-work sys event metric support such that we don't 
require "compat" or "Unit" values for a metric when the metric is 
described in terms of event aliases. That code is 2 years old, so may 
take a bit of time to rebase. I'll look to do that now.

Thanks,
John