Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers

From: John Garry
Date: Mon Jun 12 2023 - 14:16:01 EST


On 08/06/2023 10:44, Jing Zhang wrote:
Unit is the format of the event_source device name. We should match based on that as well as compat. I need to check the code again to understand how that is done... it has changed a good bit in 3 years.

This situation only happens on uncore metric. I happened to write wrong Unit, but the metric still matches.


I'm just double checking this now. I think any possible fix should be easy enough for current code but may be tricky for backport with lots of metric code changes.

Thanks,
John