Re: [PATCH v11 4/8] arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL

From: Steven Rostedt
Date: Fri Jun 09 2023 - 13:19:36 EST


On Fri, 9 Jun 2023 10:31:19 +0100
Catalin Marinas <catalin.marinas@xxxxxxx> wrote:

> On Sat, Apr 08, 2023 at 05:42:18AM -0700, Donglin Peng wrote:
> > The previous patch ("function_graph: Support recording and printing
> > the return value of function") has laid the groundwork for the for
> > the funcgraph-retval, and this modification makes it available on
> > the ARM64 platform.
> >
> > We introduce a new structure called fgraph_ret_regs for the ARM64
> > platform to hold return registers and the frame pointer. We then
> > fill its content in the return_to_handler and pass its address to
> > the function ftrace_return_to_handler to record the return value.
> >
> > Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>
> > Tested-by: Mark Rutland <mark.rutland@xxxxxxx>
> > Signed-off-by: Donglin Peng <pengdonglin@xxxxxxxxxxxxxx>
>
> We fully trust Mark's reviews ;) but just in case you need an official
> maintainer ack:
>
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Thanks Catalin, that does help.

-- Steve