Re: [PATCH] mm: kill [add|del]_page_to_lru_list()

From: Matthew Wilcox
Date: Fri Jun 09 2023 - 13:18:54 EST


On Fri, Jun 09, 2023 at 09:39:01AM +0800, Kefeng Wang wrote:
> Directly call lruvec_del_folio(), and drop unused page interfaces.

Convert isolate_migratepages_block() to actually use folios and
then we can kill the interfaces.

> +++ b/mm/compaction.c
> @@ -1145,7 +1145,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> low_pfn += compound_nr(page) - 1;
>
> /* Successfully isolated */
> - del_page_from_lru_list(page, lruvec);
> + lruvec_del_folio(lruvec, page_folio(page));

This kind of thing is not encouraged. It's just churn and gets in
the way of actual conversions.