Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative

From: Lee Jones
Date: Thu Jun 08 2023 - 12:38:53 EST


On Wed, 31 May 2023, Yang Li wrote:

> The return value from the call to cht_wc_leds_find_freq() is int.
> However, the return value is being assigned to an unsigned
> int variable 'ctrl', so making it an int.
>
> Eliminate the following warning:
> drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/leds/leds-cht-wcove.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]