Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES

From: David Howells
Date: Wed Jun 07 2023 - 13:33:07 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> > > - tls_ctx->pending_open_record_frags = true;
> > > copied += try_to_copy;
> > > +copied:
> > > + tls_ctx->pending_open_record_frags = true;
> >
> > Why move pending-open-record-frags setting if it's also set before
> > jumping?
>
> I should probably remove it from before the goto - unless you'd prefer to do
> it in both places.

Actually, I need to keep the one before the goto.

David