Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES

[David Howells]

Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> > +		if (put)
> > +			put_page(page);
> 
> is put ever set to true?

Ah, the copy-data-if-slab thing got removed.  I'll clean this bit up.

> > -		tls_ctx->pending_open_record_frags = true;
> >  		copied += try_to_copy;
> > +copied:
> > +		tls_ctx->pending_open_record_frags = true;
> 
> Why move pending-open-record-frags setting if it's also set before
> jumping?

I should probably remove it from before the goto - unless you'd prefer to do
it in both places.

David