Re: [PATCH 1/3] drm/todo: Add atomic modesetting references

From: Laurent Pinchart
Date: Fri Jun 02 2023 - 06:53:58 EST


Hi Geert,

Thank you for the patch.

On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote:
> The section about converting existing KMS drivers to atomic modesetting
> mentions the existence of a conversion guide, but does not reference it.
> While the guide is old and rusty, it still contains useful information,
> so add a link to it. Also link to the LWN.net articles that give an
> overview about the atomic mode setting design.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Documentation/gpu/todo.rst | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 68bdafa0284f55f6..51eb67f5268c5ec1 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android
> really want an atomic modeset interface, so this is all about the bright
> future.
>
> -There is a conversion guide for atomic and all you need is a GPU for a
> +There is a conversion guide for atomic[1] and all you need is a GPU for a
> non-converted driver (again virtual HW drivers for KVM are still all
> -suitable).
> +suitable). The "Atomic mode setting design overview" series [2][3] at

s/ / /

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> +LWN.net can also be helpful.
>
> As part of this drivers also need to convert to universal plane (which means
> exposing primary & cursor as proper plane objects). But that's much easier to
> do by directly using the new atomic helper driver callbacks.
>
> + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html
> + - [2] https://lwn.net/Articles/653071/
> + - [3] https://lwn.net/Articles/653466/
> +
> Contact: Daniel Vetter, respective driver maintainers
>
> Level: Advanced

--
Regards,

Laurent Pinchart