Re: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

From: Arnd Bergmann
Date: Fri May 19 2023 - 07:03:52 EST


On Fri, May 19, 2023, at 12:58, Stanley Chang[昌育德] wrote:
>>
>> I'm pretty sure that drivers/usb/phy/ is deprecated now...
>>
>> New drivers should be written for the generic PHY subsystem in
>> drivers/phy/.

Indeed, I missed that in my review.

> Thanks for your reminder.
> Will drivers/usb/phy be removed?
> Is it not allowed to add new drivers?
>
> In our application, driver/phy is not suitable.
> We need to notify the phy driver when the USB hub port status changes.
> However, generic PHY drivers are designed for various device's PHY.
> And it seems inappropriate to add this function. So we choose to use
> driver/usb/phy.

If you run into something that works in the old usbphy layer
but can't be done in drivers/phy, I think the better solution
would be to change the drivers/phy/ code to add this.

Arnd