RE: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

From: Stanley Chang[昌育德]
Date: Fri May 19 2023 - 07:00:38 EST


Hi Paul,

> > Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> > 2.0/3.0
> > controller. Added two drivers to drive the USB 2.0/3.0 PHY
> > transceivers.
> > For USB 3.0 transceivers, a driver phy-rtk-usb3 is provided.
> > The driver phy-rtk-usb2 is used to support USB 2.0 transceivers.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> > ---
> > drivers/usb/phy/Kconfig |   14 +
> > drivers/usb/phy/Makefile |    2 +
> > drivers/usb/phy/phy-rtk-usb.h |   88 ++
> > drivers/usb/phy/phy-rtk-usb2.c | 2196
> > ++++++++++++++++++++++++++++++++
> > drivers/usb/phy/phy-rtk-usb3.c | 1165 +++++++++++++++++
> > 5 files changed, 3465 insertions(+)
> > create mode 100644 drivers/usb/phy/phy-rtk-usb.h
> > create mode 100644 drivers/usb/phy/phy-rtk-usb2.c
> > create mode 100644 drivers/usb/phy/phy-rtk-usb3.c
>
> I'm pretty sure that drivers/usb/phy/ is deprecated now...
>
> New drivers should be written for the generic PHY subsystem in
> drivers/phy/.
>
Thanks for your reminder.
Will drivers/usb/phy be removed?
Is it not allowed to add new drivers?

In our application, driver/phy is not suitable.
We need to notify the phy driver when the USB hub port status changes.
However, generic PHY drivers are designed for various device's PHY.
And it seems inappropriate to add this function. So we choose to use driver/usb/phy.

Thanks,
Stanley