Re: [PATCH v2 1/2] dt-bindings: usb: Add microchip USB5807 HUB

[Mike Looijmans]

See below (mailserver has a top-post fetish)


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@xxxxxxxxxxxxxxxxx
W: www.topic.nl

Please consider the environment before printing this e-mail
On 15-05-2023 12:38, Krzysztof Kozlowski wrote:
> On 15/05/2023 08:25, Mike Looijmans wrote:
> > The USB5807 is a 7-port USB 3.1 hub that can be configured by I2C.
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +
> > +  swap-dx-lanes:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    maxItems: 8
> Missing minItems. Bug in the other binding caused this one to be hidden.

Will add "minItems: 0" in v3...

I initially based the code and binding on the usb251xb. Later found the 
mismatch and fixed it, but somehow forgot that I copied the "int8-array" 
too.

> > +    description:
> > +      Specifies the ports which will swap the differential-pair (D+/D-),
> > +      default is not-swapped.
>
> Best regards,
> Krzysztof

--
Mike Looijmans