Re: [PATCH v2 1/2] dt-bindings: usb: Add microchip USB5807 HUB

From: Krzysztof Kozlowski
Date: Mon May 15 2023 - 06:39:03 EST


On 15/05/2023 08:25, Mike Looijmans wrote:
> The USB5807 is a 7-port USB 3.1 hub that can be configured by I2C.


Thank you for your patch. There is something to discuss/improve.

> +
> + swap-dx-lanes:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + maxItems: 8

Missing minItems. Bug in the other binding caused this one to be hidden.

> + description:
> + Specifies the ports which will swap the differential-pair (D+/D-),
> + default is not-swapped.


Best regards,
Krzysztof