Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

[Geert Uytterhoeven]

Hi Bagas,

On Fri, May 12, 2023 at 12:08 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote:
> Replace GPL boilerplate notice on remaining files with appropriate SPDX
> tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+.
>
> Cc: David A. Hinds <dahinds@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Donald Becker <becker@xxxxxxxxx>
> Cc: Peter De Schrijver <p2@xxxxxxx>
> Cc: Topi Kanerva <topi@xxxxxxxxxxxxxxx>
> Cc: Alain Malek <Alain.Malek@xxxxxxxxxxx>
> Cc: Bruce Abbott <bhabbott@xxxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxx>
> Acked-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Signed-off-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

Thanks for your patch!

> --- a/drivers/net/ethernet/8390/apne.c
> +++ b/drivers/net/ethernet/8390/apne.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-1.0+

As per the removed lines below, this should be GPL-2.0-only.

>  /*
>   * Amiga Linux/68k 8390 based PCMCIA Ethernet Driver for the Amiga 1200
>   *
> @@ -19,12 +20,6 @@
>   *
>   * ----------------------------------------------------------------------------
>   *
> - * This file is subject to the terms and conditions of the GNU General Public
> - * License.  See the file COPYING in the main directory of the Linux
> - * distribution for more details.
> - *
> - * ----------------------------------------------------------------------------
> - *
>   */
>
>

> --- a/drivers/net/ethernet/8390/hydra.c
> +++ b/drivers/net/ethernet/8390/hydra.c
> @@ -1,10 +1,8 @@
> +// SPDX-License-Identifier: GPL-1.0+

Likewise.

> +
>  /* New Hydra driver using generic 8390 core */
>  /* Based on old hydra driver by Topi Kanerva (topi@xxxxxxxxxxxxxxx) */
>
> -/* This file is subject to the terms and conditions of the GNU General      */
> -/* Public License.  See the file COPYING in the main directory of the       */
> -/* Linux distribution for more details.                                     */
> -
>  /* Peter De Schrijver (p2@xxxxxxx) */
>  /* Oldenburg 2000 */
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds