Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()

From: Simon Horman
Date: Wed May 10 2023 - 04:16:46 EST


On Tue, May 09, 2023 at 04:49:46PM -0700, Jesse Brandeburg wrote:
> On 5/9/2023 4:46 AM, Yunsheng Lin wrote:
> > The remaining users calling __skb_frag_set_page() with
> > page being NULL seems to be doing defensive programming,
> > as shinfo->nr_frags is already decremented, so remove
> > them.
> >
> > Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> > ---
> > RFC: remove a local variable as pointed out by Simon.
>
> Makes sense.
>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
>
> CC: Simon

Thanks Yunsheng and Jessee,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>