Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()

From: Jesse Brandeburg
Date: Tue May 09 2023 - 19:49:59 EST


On 5/9/2023 4:46 AM, Yunsheng Lin wrote:
> The remaining users calling __skb_frag_set_page() with
> page being NULL seems to be doing defensive programming,
> as shinfo->nr_frags is already decremented, so remove
> them.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> ---
> RFC: remove a local variable as pointed out by Simon.

Makes sense.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>

CC: Simon