Re: [RFC PATCH 3/4] rculist.h: Fix parentheses around macro pointer parameter use

From: Steven Rostedt
Date: Fri May 05 2023 - 11:02:22 EST


On Fri, 5 May 2023 10:35:39 -0400
Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:

> >> Yeah it is not clear why anyone would ever want to use it like this.
> >> Why don't they just pass t1 to list_for_each_entry_rcu() ? I would
> >> rather it break them and they re-think their code ;).
> >
> > Remember interfaces should not be enforcing policy unless it's key to the
> > way the interface works.
>
> Oh yeah, 100% agree. I am not particularly against this particular patch
> but I also dont see it as solving any problem. Feel free to Ack the patch
> if you feel strongly about wanting it.

I agree that this isn't solving any real bugs, but it is a legitimate
cleanup.

And as someone that tends to push interfaces to their limits, I would
likely be the one that hits it ;-)

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve