Re: [RFC 07/11] Documentation/hwmon: Revise sysfs interface specification

From: James Seo
Date: Fri May 05 2023 - 11:01:24 EST


On Fri, May 05, 2023 at 11:51:03AM +0700, Bagas Sanjaya wrote:
> On Thu, May 04, 2023 at 12:57:48AM -0700, James Seo wrote:
>> +**RO** Read-only value.
>> +**WO** Write-only value.
>> +**RW** Read/write value.
>
> Why are the permissions be emphasized?

I don't remember, to be honest. I will deemphasize permissions.

>
>> +| | ``pwm[1-*]_auto_point[1-*]_pwm`` | **RW** | PWM temperature curve definition |
>> +| | ``pwm[1-*]_auto_point[1-*]_temp`` | | for chips that associate trip |
>> +| | ``pwm[1-*]_auto_point[1-*]_temp_hyst`` | | points with PWM output channels. |
>> ++-------------------------------------------+--------+-------------------------------------+
>> +| | ``temp[1-*]_auto_point[1-*]_pwm`` | **RW** | PWM temperature curve definition |
>> +| | ``temp[1-*]_auto_point[1-*]_temp`` | | for chips that associate trip |
>> +| | ``temp[1-*]_auto_point[1-*]_temp_hyst`` | | points with temperature channels. |
>
> Dunno if replacing line blocks with bullet lists should improve the semantic
> of three sysfs files having the same description.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara

These are line blocks, not bullet lists. They ensure that each
attribute name is on its own line, avoiding strange wrapping like:

pwm[1-*]_auto_point[1-*]_pwm pwm[1-*]_auto
_point[1-*]_temp pwm[1-*]_auto_point[1-*]_temp_hyst