Re: [PATCH] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

[Linus Walleij]

Hi Manikanta,

thanks for your patch!

On Wed, Apr 12, 2023 at 4:52 PM Manikanta Guntupalli
<manikanta.guntupalli@xxxxxxx> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xxxxxxx>

Don't you need to also add
gpiochip_disable_irq() in the .irq_mask() callback and
gpiochip_enable_irq() in the .irq_unmask() callback as we
do in most other conversions?

Example:
https://lore.kernel.org/linux-gpio/20230414-immutable-irqchips-2-v1-3-6b59a5186b00@xxxxxxxxxx/

Yours,
Linus Walleij