Re: ntfs orphan? (was Re: [PATCH] ntfs: do not dereference a null ctx on error)

From: Christian Brauner
Date: Thu May 04 2023 - 06:57:28 EST


On Wed, May 03, 2023 at 02:06:09PM -0700, Andrew Morton wrote:
> On Wed, 3 May 2023 11:16:02 +0700 Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote:
>
> > On Fri, Apr 07, 2023 at 07:44:33PM +0000, Danila Chernetsov wrote:
> > > In ntfs_mft_data_extend_allocation_nolock(), if an error condition occurs
> > > prior to 'ctx' being set to a non-NULL value, avoid dereferencing the NULL
> > > 'ctx' pointer in error handling.
> > >
> > > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Duplicate of 10-years-old outstanding patch at [1].
>
> Well, the patches are actually quite different. Is Danila's longer one
> better?
>
> > I'm not speaking of the patch itself but rather on unfortunate state
> > of ntfs subsystem. It seems like the maintainer is MIA (has not
> > responding to patch submissions for a long time). Some trivial
> > patches, however, are merged through mm tree.
> >
> > Konstantin (from newer ntfs3 subsystem), Andrew, would you like to take a
> > look on this orphaned subsystem (and help reviewing)? I'd like to send
> > MAINTAINERS update if it turns out to be the case.
> >
>
> Sure, I can join linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx and hendle things
> which come along.
>
> Or Christian may want to do that?

Thanks for asking. I would be able to pick up those patches into
fs.misc. I got an off-list ping about someone also wanting to help
with review apparently.