Re: [PATCH 2/2] Input: tests - modular KUnit tests should not depend on KUNIT=y

From: David Gow
Date: Thu May 04 2023 - 02:29:42 EST


On Tue, 2 May 2023 at 18:17, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:
>
> While KUnit tests that cannot be built as a loadable module must depend
> on "KUNIT=y", this is not true for modular tests, where it adds an
> unnecessary limitation.
>
> Fix this by relaxing the dependency to "KUNIT".
>
> Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---

Works here, thanks!

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

> drivers/input/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
> index 735f90b74ee5ad44..3bdbd34314b3495a 100644
> --- a/drivers/input/Kconfig
> +++ b/drivers/input/Kconfig
> @@ -168,7 +168,7 @@ config INPUT_EVBUG
>
> config INPUT_KUNIT_TEST
> tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS
> - depends on INPUT && KUNIT=y
> + depends on INPUT && KUNIT
> default KUNIT_ALL_TESTS
> help
> Say Y here if you want to build the KUnit tests for the input
> --
> 2.34.1
>