Re: [PATCH] lkdtm: replace ll_rw_block with submit_bh

From: Kees Cook
Date: Wed May 03 2023 - 21:14:41 EST


On Thu, May 04, 2023 at 12:29:44AM +0800, Yue Zhao wrote:
> Function ll_rw_block was removed in commit 79f597842069 ("fs/buffer:
> remove ll_rw_block() helper"). There is no unified function to sumbit
> read or write buffer in block layer for now. Consider similar sematics,
> we can choose submit_bh() to replace ll_rw_block() as predefined crash
> point. In submit_bh(), it also takes read or write flag as the first
> argument and invoke submit_bio() to submit I/O request to block layer.
>
> Fixes: 79f597842069 ("fs/buffer: remove ll_rw_block() helper")
>
> Signed-off-by: Yue Zhao <findns94@xxxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook