Re: [PATCH v2 21/21] KVM:x86: Support CET supervisor shadow stack MSR access

[Yang, Weijiang]

On 5/4/2023 1:06 AM, Edgecombe, Rick P wrote:
> On Fri, 2023-04-21 at 09:46 -0400, Yang Weijiang wrote:
> > @@ -2471,6 +2495,12 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu,
> > struct msr_data *msr_info)
> >                  else
> >                          kvm_set_xsave_msr(msr_info);
> >                  break;
> > +       case MSR_IA32_PL0_SSP ... MSR_IA32_PL2_SSP:
> > +       case MSR_IA32_INT_SSP_TAB:
> > +               if (!cet_is_msr_accessible(vcpu, msr_info))
> > +                       return 1;
> > +               kvm_set_xsave_msr(msr_info);
> > +               break;
> These are supposed to be canonical too, right?

Yes, I'll add check in next version, thanks!