Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes

[Miguel Ojeda]

On Wed, May 3, 2023 at 12:45 PM Benno Lossin <benno.lossin@xxxxxxxxx> wrote:
>
> A couple of nits for the commit message (these can be
> applied by Miguel when picking the patch, if he agrees):

Given this is one of the "get yourself familiarized with the kernel's
development process" issues that I create from time to time, it is a
good opportunity for Roy to fix those and send a v2.

Roy, could you please do that? Please pass `-v2` to `git format-patch`
when you do so, then also collect the two `Reviewed-by`s you got and
put them above your `Signed-off-by`.

> - capitalize 'Rust',
> - add a `.` at the end,
> - remove the newline between the tags.

Also: typo "idoms" -> "idioms", and the title could be improved to:

    rust: bindings: sort `#include`s of `bindings_helper.h`

since "rust/bindings" is already given by the prefixes etc.

However, what does it mean "...and rust idoms"? This is C code, not
Rust code, and thus it should follow kernel C idioms (which, in some
cases, do sort the `#include`s too, so that is fine).

Perhaps remove that bit, or say instead "Rust subsystem idioms"
instead (since we do want to keep them sorted :)

Thanks!

Cheers,
Miguel