Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes

[Benno Lossin]

On 27.04.23 00:57, materoy@xxxxxxxxx wrote:
> From: Roy Matero <materoy@xxxxxxxxx>
> 
> Fix sorting of rust/bindings/binding_helper.h's includes,
> to maintain consistency and rust idoms
> 
> Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1002
> 
> Signed-off-by: Roy Matero <materoy@xxxxxxxxx>

A couple of nits for the commit message (these can be
applied by Miguel when picking the patch, if he agrees):
- capitalize 'Rust',
- add a `.` at the end,
- remove the newline between the tags.

I am not sure if the tags at the end should be sorted in any
way.

Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>

> ---
>   rust/bindings/bindings_helper.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index 50e7a76d5455..dc8d97272e71 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -6,10 +6,10 @@
>    * Sorted alphabetically.
>    */
> 
> -#include <linux/slab.h>
>   #include <linux/refcount.h>
> -#include <linux/wait.h>
>   #include <linux/sched.h>
> +#include <linux/slab.h>
> +#include <linux/wait.h>
> 
>   /* `bindgen` gets confused at certain things. */
>   const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
> --
> 2.40.1
> 

-- 
Cheers,
Benno