Re: [PATCH v3 03/46] perf stat: Introduce skippable evsels

[Liang, Kan]

On 2023-05-01 4:48 p.m., Ian Rogers wrote:
> On Mon, May 1, 2023 at 1:25 PM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
>>
>>
>> On 2023-05-01 11:29 a.m., Ian Rogers wrote:
>>> The events are displayed twice as there are 2 groups of events. This
>>> is changed by:
>>> https://lore.kernel.org/lkml/20230429053506.1962559-5-irogers@xxxxxxxxxx/
>>> where the events are no longer grouped.
>> The trick seems don't work on a hybrid machine. I still got the
>> duplicate Topdown events on e-core.
> For hybrid the rest of the patch series is necessary, ie the patches
> beyond what's for 6.4, which I take from the output (ie not a crash)
> you are looking at. As multiple groups are in play then it looks like
> the atom events are on >1 PMU which can happen as the x86 code special
> cases events with topdown in their name. Some fixes in the series for
> this are:
> https://lore.kernel.org/lkml/20230429053506.1962559-6-irogers@xxxxxxxxxx/
> https://lore.kernel.org/lkml/20230429053506.1962559-40-irogers@xxxxxxxxxx/
> and related:
> https://lore.kernel.org/lkml/20230429053506.1962559-19-irogers@xxxxxxxxxx/
> and so fixing this requires some detective work.
>

I applied all the patches of the series when I did the test on hybrid.
The above patches don't help.


> I don't think it should be a requirement for the series that all
> hybrid bugs are fixed - especially given the complaints against the
> length of the series as-is.

I agree especially considering the metrics have been broken on the
hybrid for a while.

I just want to do a complete test and understand what is going to fixed
and what hasn't.

Thanks,
Kan