RE: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware interaction

[Gupta, Nipun]

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> On
> Behalf Of Geert Uytterhoeven
> Sent: Friday, April 28, 2023 1:44 PM
> To: Gupta, Nipun <Nipun.Gupta@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx; eric.auger@xxxxxxxxxx;
> alex.williamson@xxxxxxxxxx; cohuck@xxxxxxxxxx;
> song.bao.hua@xxxxxxxxxxxxx; mchehab+huawei@xxxxxxxxxx; maz@xxxxxxxxxx;
> f.fainelli@xxxxxxxxx; jeffrey.l.hugo@xxxxxxxxx; saravanak@xxxxxxxxxx;
> Michael.Srba@xxxxxxxxx; mani@xxxxxxxxxx; yishaih@xxxxxxxxxx;
> jgg@xxxxxxxx; jgg@xxxxxxxxxx; robin.murphy@xxxxxxx; will@xxxxxxxxxx;
> joro@xxxxxxxxxx; masahiroy@xxxxxxxxxx; ndesaulniers@xxxxxxxxxx;
> rdunlap@xxxxxxxxxxxxx; baolu.lu@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kbuild@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; okaya@xxxxxxxxxx;
> Anand, Harpreet <harpreet.anand@xxxxxxx>; Agarwal, Nikhil
> <nikhil.agarwal@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; Jansen
> Van Vuuren, Pieter <pieter.jansen-van-vuuren@xxxxxxx>; Cascon, Pablo
> <pablo.cascon@xxxxxxx>; git (AMD-Xilinx) <git@xxxxxxx>
> Subject: Re: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware
> interaction
> 
> 
> Hi Nipun,
> 
> On Mon, Mar 13, 2023 at 2:28 PM Nipun Gupta <nipun.gupta@xxxxxxx>
> wrote:
> > The MCDI (Management CPU Driver Interface) is used as a
> > protocol to communicate with the RPU firmware. It has
> > pre-defined set of messages for different message exchanges
> > between APU and RPU.
> >
> > Signed-off-by: Puneet Gupta <puneet.gupta@xxxxxxx>
> > Signed-off-by: Nipun Gupta <nipun.gupta@xxxxxxx>
> > Signed-off-by: Tarak Reddy <tarak.reddy@xxxxxxx>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@xxxxxxx>
> 
> Thanks for your patch, which is now commit eb96b740192b2a09 ("cdx:
> add MCDI protocol interface for firmware interaction") upstream.
> 
> > --- /dev/null
> > +++ b/drivers/cdx/controller/Kconfig
> > @@ -0,0 +1,20 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
> > +# CDX controller configuration
> > +#
> > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc.
> > +#
> > +
> > +if CDX_BUS
> > +
> > +config MCDI_LOGGING
> > +       bool "MCDI Logging for the CDX controller"
> > +       depends on CDX_CONTROLLER
> > +       help
> > +         Enable MCDI Logging for
> > +         the CDX Controller for debug
> > +         purpose.
> > +
> > +         If unsure, say N.
> > +
> > +endif
> 
> As there also exist config symbols SFC_MCDI_LOGGING and
> SFC_SIENA_MCDI_LOGGING, perhaps MCDI_LOGGING is too generic, and
> should
> be renamed to CDX_MCDI_LOGGING?

Sure, we will add a patch to rename this.

Thanks,
Nipun

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel