Re: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware interaction

[Geert Uytterhoeven]

Hi Nipun,

On Mon, Mar 13, 2023 at 2:28 PM Nipun Gupta <nipun.gupta@xxxxxxx> wrote:
> The MCDI (Management CPU Driver Interface) is used as a
> protocol to communicate with the RPU firmware. It has
> pre-defined set of messages for different message exchanges
> between APU and RPU.
>
> Signed-off-by: Puneet Gupta <puneet.gupta@xxxxxxx>
> Signed-off-by: Nipun Gupta <nipun.gupta@xxxxxxx>
> Signed-off-by: Tarak Reddy <tarak.reddy@xxxxxxx>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>
> Tested-by: Nikhil Agarwal <nikhil.agarwal@xxxxxxx>

Thanks for your patch, which is now commit eb96b740192b2a09 ("cdx:
add MCDI protocol interface for firmware interaction") upstream.

> --- /dev/null
> +++ b/drivers/cdx/controller/Kconfig
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# CDX controller configuration
> +#
> +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc.
> +#
> +
> +if CDX_BUS
> +
> +config MCDI_LOGGING
> +       bool "MCDI Logging for the CDX controller"
> +       depends on CDX_CONTROLLER
> +       help
> +         Enable MCDI Logging for
> +         the CDX Controller for debug
> +         purpose.
> +
> +         If unsure, say N.
> +
> +endif

As there also exist config symbols SFC_MCDI_LOGGING and
SFC_SIENA_MCDI_LOGGING, perhaps MCDI_LOGGING is too generic, and should
be renamed to CDX_MCDI_LOGGING?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds