Re: [RFC v2 3/3] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol

[Krzysztof Kozlowski]

On 26/04/2023 15:26, Oleksii Moisieiev wrote:
> Add new SCMI v3.2 pinctrl protocol bindings definitions and example.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed several entries, including DT list, so this won't be tested.
I won't be doing full review, no point if patch is not tested.

> ---
>  .../bindings/firmware/arm,scmi.yaml           | 77 +++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 2f7c51c75e85..41ba5b8d8151 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -212,6 +212,63 @@ properties:
>        reg:
>          const: 0x18
>  
> +  protocol@19:
> +    $ref: '#/$defs/protocol-node'
> +
> +    properties:
> +      reg:
> +        const: 0x19
> +
> +      '#pinctrl-cells':
> +        const: 0
> +
> +    allOf:
> +      - $ref: "/schemas/pinctrl/pinctrl.yaml#"

Drop quotes.

> +
> +    required:
> +      - reg
> +
> +    additionalProperties:
> +      anyOf:
> +        - type: object
> +          allOf:
> +            - $ref: /schemas/pinctrl/pincfg-node.yaml#
> +            - $ref: /schemas/pinctrl/pinmux-node.yaml#
> +
> +          description:
> +            A pin multiplexing sub-node describe how to configure a
> +            set of pins is some desired function.
> +            A single sub-node may define several pin configurations.
> +            This sub-node is using default pinctrl bindings to configure
> +            pin multiplexing and using SCMI protocol to apply specified
> +            configuration using SCMI protocol.
> +
> +          properties:
> +            phandle: true

What's this?

> +            function: true
> +            groups: true
> +            pins: true
> +            bias-bus-hold: true
> +            bias-disable: true
> +            bias-high-impedance: true
> +            bias-pull-up: true
> +            bias-pull-default: true
> +            bias-pull-down: true
> +            drive-open-drain: true
> +            drive-open-source: true
> +            drive-push-pull: true
> +            drive-strength: true
> +            input-debounce: true
> +            input-value: true
> +            input-schmitt: true
> +            low-power-mode: true
> +            output-mode: true
> +            output-value: true
> +            power-source: true
> +            skew-rate: true
> +
> +          additionalProperties: true

This should be false... but if it is true, then listing all properties
does not make sense. And anyway usual way is to make it instead
unevaluatedProperties:false. I have troubles understanding your goal here.

Best regards,
Krzysztof