Re: [PATCH] crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs()

From: Herbert Xu
Date: Fri Apr 28 2023 - 06:05:57 EST


On Mon, Apr 17, 2023 at 10:25:09PM +0200, Christophe JAILLET wrote:
> SS_ENCRYPTION is (0 << 7 = 0), so the test can never be true.
> Use a direct comparison to SS_ENCRYPTION instead.
>
> The same king of test is already done the same way in sun8i_ss_run_task().
>
> Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Untested
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt