Re: [PATCH 02/17] fs: remove the special !CONFIG_BLOCK def_blk_fops

From: Keith Busch
Date: Mon Apr 24 2023 - 15:37:28 EST


On Mon, Apr 24, 2023 at 12:22:30PM -0700, Randy Dunlap wrote:
> On 4/23/23 22:49, Christoph Hellwig wrote:
> > + if (IS_ENABLED(CONFIG_BLOCK))
> > + inode->i_fop = &def_blk_fops;
>
> It looks like def_blk_fops is being removed (commit message and patch
> fragment below), but here (above line) it is being used.
>
> Am I just confused?

The def_blk_fops is removed only for the !CONFIG_BLOCK case. Its usage is under
a branch known at compile time, so it's optimized out for that case before
trying to resolve the symbol.