Re: [PATCH 0/5] ubi: Enhanced fault injection capability for the UBI driver

From: ZhaoLong Wang
Date: Sun Apr 23 2023 - 08:54:35 EST


Thank you very much for replying to my email. I agree with you.

I'll tweak my patch in the next few weeks, try to keep the old interface and
be compatible with the new interface.

Best Regards
ZhaoLong Wang

在 2023/4/22 5:18, Richard Weinberger 写道:
----- Ursprüngliche Mail -----
Von: "ZhaoLong Wang" <wangzhaolong1@xxxxxxxxxx>
The existing fault injection capability of UBI is too simple.
It uses hard-coded fault probability values and lacks other
configurable options. As a result, these interfaces are difficult
to use when digging defects in the abnormal path of code and
reproducing some problems.

The kernel provides a powerful fault injection framework, which
provides rich configurable fault injection attributes during runtime.
So it can be used to improve the fault injection capability of the
UBI driver.

This series of patches refactor the existing fault injection interface
and add some fault injection types to help testers and developers
find potential problems in the code.
In general I like having some new and advanced way to test UBI.
But your patches seem to remove the old interface from debugfs,
this will cause breakage of existing test scripts.

So please keep the old interface too.

Thanks,
//richard