Re: [PATCH v3 3/4] mfd: intel-m10-bmc: Move m10bmc_sys_read() away from header

From: Xu Yilun
Date: Thu Apr 20 2023 - 04:09:41 EST


On 2023-04-17 at 12:26:52 +0300, Ilpo Järvinen wrote:
> Move m10bmc_sys_read() out from the header to prepare it for adding
> more code into the function which would make it too large to be a
> static inline any more.
>
> While at it, replace the vague wording in function comment with more
> precise statements.
>
> Reviewed-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> # For hwmon
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>

> ---
> drivers/hwmon/intel-m10-bmc-hwmon.c | 1 +
> drivers/mfd/intel-m10-bmc-core.c | 14 ++++++++++++++
> include/linux/mfd/intel-m10-bmc.h | 17 +----------------
> 3 files changed, 16 insertions(+), 16 deletions(-)