Re: [PATCH 03/11] drm/msm/dpu: use hsync/vsync polarity set by the encoder

[Dmitry Baryshkov]

On 19/04/2023 17:41, Arnaud Vrac wrote:
> Do not override the hsync/vsync polarity passed by the encoder when
> setting up intf timings. The same logic was used in both the encoder and
> intf code to set the DP and DSI polarities, so those interfaces are not
> impacted. However for HDMI, the polarities were overriden to static
> values based on the vertical resolution, instead of using the actual
> mode polarities.
>
> Signed-off-by: Arnaud Vrac <avrac@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 16 +++-------------
>   1 file changed, 3 insertions(+), 13 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

As a side note: I think at some point we should get rid of the override 
in dpu_encoder too and move it to dsi bridge code.

--
With best wishes
Dmitry