Re: [PATCH v2 1/5] brcmfmac: Drop all the RAW device IDs

From: Arend Van Spriel
Date: Thu Feb 02 2023 - 12:19:41 EST


On February 2, 2023 6:25:28 AM "'Hector Martin' via BRCM80211-DEV-LIST,PDL" <brcm80211-dev-list.pdl@xxxxxxxxxxxx> wrote:

On 31/01/2023 23.17, Jonas Gorski wrote:
On Tue, 31 Jan 2023 at 12:36, Hector Martin <marcan@xxxxxxxxx> wrote:

These device IDs are only supposed to be visible internally, in devices
without a proper OTP. They should never be seen in devices in the wild,
so drop them to avoid confusion.

I think these can still show up in embedded platforms where the
OTP/SPROM is provided on-flash.

E.g. https://forum.archive.openwrt.org/viewtopic.php?id=55367&p=4
shows this bootlog on an BCM4709A0 router with two BCM43602 wifis:

[ 3.237132] pci 0000:01:00.0: [14e4:aa52] type 00 class 0x028000
[ 3.237174] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x00007fff 64bit]
[ 3.237199] pci 0000:01:00.0: reg 0x18: [mem 0x00000000-0x003fffff 64bit]
[ 3.237302] pci 0000:01:00.0: supports D1 D2
...
[ 3.782384] pci 0001:03:00.0: [14e4:aa52] type 00 class 0x028000
[ 3.782440] pci 0001:03:00.0: reg 0x10: [mem 0x00000000-0x00007fff 64bit]
[ 3.782474] pci 0001:03:00.0: reg 0x18: [mem 0x00000000-0x003fffff 64bit]
[ 3.782649] pci 0001:03:00.0: supports D1 D2

0xaa52 == 43602 (BRCM_PCIE_43602_RAW_DEVICE_ID)

Rafał can probably provide more info there.

Regards
Jonas

Arend, any comments on these platforms?

Huh? I already replied to that couple of days ago or did I only imagine doing that.

Regards,
Arend



Attachment: smime.p7s
Description: S/MIME Cryptographic Signature