Re: [PATCH 2/2] spi: intel: Add support for controllers

[ALOK TIWARI]

9d24 and 9da4 should come after { PCI_VDEVICE(INTEL, 0x7e23), (unsigned 
long)&cnl_info

and a2a4  should be after { PCI_VDEVICE(INTEL, 0xa224), (unsigned 
long)&bxt_info }

Thanks,

Alok

On 2/1/2023 11:19 AM, Mika Westerberg wrote:
> On Wed, Feb 01, 2023 at 02:04:55AM -0300, Mauro Lima wrote:
> > Add Device IDs to the module table for the following controllers:
> > 	- 9da4  Cannon Lake 300 Series On-Package
> > 	- a2a4  200 Series/Z370 Chipset Family SPI Controller
> > 	- 9d24  Intel® 200 Series Chipset Family (Including Intel® X299),
> > 		Intel® Z370 Intel® H310C,B365,
> > 		also Intel® B460 and H410 Chipset Platform Controller Hub
> >
> > Signed-off-by: Mauro Lima <mauro.lima@xxxxxxxxxxxxx>
> > ---
> >   drivers/spi/spi-intel-pci.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/spi-intel-pci.c b/drivers/spi/spi-intel-pci.c
> > index 10fa3a7fa4f5..ba08f64e56eb 100644
> > --- a/drivers/spi/spi-intel-pci.c
> > +++ b/drivers/spi/spi-intel-pci.c
> > @@ -80,6 +80,9 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
> >   	{ PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
> >   	{ PCI_VDEVICE(INTEL, 0xa324), (unsigned long)&cnl_info },
> >   	{ PCI_VDEVICE(INTEL, 0xa3a4), (unsigned long)&cnl_info },
> > +	{ PCI_VDEVICE(INTEL, 0x9da4), (unsigned long)&cnl_info },
> > +	{ PCI_VDEVICE(INTEL, 0xa2a4), (unsigned long)&cnl_info },
> > +	{ PCI_VDEVICE(INTEL, 0x9d24), (unsigned long)&cnl_info },
> Make sure these are sorted numerically.
>
> Otherwise looks good, thanks for doing this!