Re: [PATCH 3/6] arm64: defconfig: Enable ipq6018 apss clock and PLL controller

[Devi Priya]

Thanks for taking time to review the patch

On 1/31/2023 3:01 PM, Dmitry Baryshkov wrote:
> On 13/01/2023 16:36, devi priya wrote:
> > Enable the PLL controller and IPQ6018 APSS clock controller
>
> ... it is used on several IPQ platforms to clock the CPU so it should be 
> enabled and built-in.
Okay, got it. Will update the commit message as suggested in V2
> > Co-developed-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
>
> Just to check: is the capitalization correct in your name here and 
> everywhere else? (please excuse my ignorance here, I do not know all the 
> spelling/capitalization rules).
Sure, will change the naming style to Camel Case
> > ---
> >   arch/arm64/configs/defconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index e0ae0996d5ad..8de3979b10a3 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1092,6 +1092,7 @@ CONFIG_QCOM_CLK_APCS_MSM8916=y
> >   CONFIG_QCOM_CLK_APCC_MSM8996=y
> >   CONFIG_QCOM_CLK_SMD_RPM=y
> >   CONFIG_QCOM_CLK_RPMH=y
> > +CONFIG_IPQ_APSS_6018=y
> >   CONFIG_IPQ_GCC_6018=y
> >   CONFIG_IPQ_GCC_8074=y
> >   CONFIG_IPQ_GCC_9574=y
Best Regards,
Devi Priya