Re: [PATCH] soc: mediatek: mtk-svs: Enable the IRQ later

[Matthias Brugger]

On 20/12/2022 12:03, Roger Lu (陸瑞傑) wrote:
> Hi Matthias Sir,
>
> After applying this patch, SVS probes fail as below on my MT8192 platform. If
> thing isn't too late, please do not merge this patch. I'll ask Ricardo how to
> reproduce this issue and give the correct solution. Thanks in advance.

Ok, I just dropped the patch from v6.2-tmp/soc branch.

Regards,
Matthias

> #MT8192 platform SVS probe fail log
> [   10.209430]  SVSB_GPU_LOW: init02 completion timeout
> [   10.214402] mtk-svs 1100b000.svs: svs start fail: -16
> [   10.219479] mtk-svs: probe of 1100b000.svs failed with error -16
>
> Hi Ricardo,
>
> Could you share us how you reproduce this issue? I have MT8192 Chromebook and
> can give it a try to reproduce the issue you encountered. Thanks a lot.
>
> Sincerely,
> Roger Lu.
>
> On Fri, 2022-12-16 at 13:47 +0100, Matthias Brugger wrote:
> > On 30/11/2022 12:00, AngeloGioacchino Del Regno wrote:
> > > Il 27/11/22 21:22, Ricardo Ribalda ha scritto:
> > > > If the system does not come from reset (like when is booted via
> > > > kexec()), the peripheral might triger an IRQ before the data structures
> > > > are initialised.
> > > > 
> > > > Fixes:
> > > > 
> > > > [    0.227710] Unable to handle kernel NULL pointer dereference at
> > > > virtual 
> > > > address 0000000000000f08
> > > > [    0.227913] Call trace:
> > > > [    0.227918]  svs_isr+0x8c/0x538
> > > > 
> > > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> > > 
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > 
> > > 
> >
> > Applied thanks!
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!