Re: [PATCH] soc: mediatek: mtk-svs: Enable the IRQ later

[AngeloGioacchino Del Regno]

Il 20/12/22 12:03, Roger Lu (陸瑞傑) ha scritto:
> Hi Matthias Sir,
>
> After applying this patch, SVS probes fail as below on my MT8192 platform. If
> thing isn't too late, please do not merge this patch. I'll ask Ricardo how to
> reproduce this issue and give the correct solution. Thanks in advance.
>
> #MT8192 platform SVS probe fail log
> [   10.209430]  SVSB_GPU_LOW: init02 completion timeout
> [   10.214402] mtk-svs 1100b000.svs: svs start fail: -16
> [   10.219479] mtk-svs: probe of 1100b000.svs failed with error -16
>
> Hi Ricardo,
>
> Could you share us how you reproduce this issue? I have MT8192 Chromebook and
> can give it a try to reproduce the issue you encountered. Thanks a lot.

Boot a kernel with Kexec to reproduce.

Regards,
Angelo

> Sincerely,
> Roger Lu.
>
> On Fri, 2022-12-16 at 13:47 +0100, Matthias Brugger wrote:
> > On 30/11/2022 12:00, AngeloGioacchino Del Regno wrote:
> > > Il 27/11/22 21:22, Ricardo Ribalda ha scritto:
> > > > If the system does not come from reset (like when is booted via
> > > > kexec()), the peripheral might triger an IRQ before the data structures
> > > > are initialised.
> > > >
> > > > Fixes:
> > > >
> > > > [    0.227710] Unable to handle kernel NULL pointer dereference at
> > > > virtual
> > > > address 0000000000000f08
> > > > [    0.227913] Call trace:
> > > > [    0.227918]  svs_isr+0x8c/0x538
> > > >
> > > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> > >
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> > Applied thanks!