Re: [PATCH 7/7] s390/vfio_ap: always clean up IRQ resources

[Anthony Krowiak]

On 12/19/22 9:10 AM, Halil Pasic wrote:
> On Tue, 13 Dec 2022 10:44:37 -0500
> Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote:
>
> > Clean up IRQ resources even when a PQAP(ZAPQ) function fails with an error
> > not handled by a case statement.
> Why?


If the ZAPQ failed, then instructions submitted to the same queue will 
likewise fail. Are you saying it's not safe to assume, therefore, that 
interrupts will not be occurring?


> I'm afraid this is a step in the wrong direction...


Please explain why.


> > Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> > ---
> >   drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> > index e80c5a6b91be..2dd8db9ddb39 100644
> > --- a/drivers/s390/crypto/vfio_ap_ops.c
> > +++ b/drivers/s390/crypto/vfio_ap_ops.c
> > @@ -1676,7 +1676,7 @@ static int vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q)
> >   		     "PQAP/ZAPQ for %02x.%04x failed with invalid rc=%u\n",
> >   		     AP_QID_CARD(q->apqn), AP_QID_QUEUE(q->apqn),
> >   		     status.response_code);
> > -		return -EIO;
> > +		break;
> >   	}
> >   
> >   	vfio_ap_free_aqic_resources(q);