Re: [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type

From: Andy Shevchenko
Date: Tue Dec 20 2022 - 05:59:14 EST


On Mon, Dec 19, 2022 at 11:35:38AM -0800, Randy Dunlap wrote:
> On 12/19/22 01:44, Andy Shevchenko wrote:
> > On Sun, Dec 18, 2022 at 07:19:00PM +0900, Hyeonggon Yoo wrote:

...

> > #define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) }
> > ...
> > #undef DEF_PAGETYPE_MASK
> >
> > In this case it decreases the chances of typo in the strings and flags.
>
> I'd say Yes. (and #undef DEF_PAGETYPE_NAME methinks; or change both to _MASK)

Ah, it's me who used two different names for the same macro :-)

--
With Best Regards,
Andy Shevchenko