Re: [PATCH net-next 01/12] net: dpaa2-eth: don't use -ENOTSUPP error code

From: Andrew Lunn
Date: Tue Nov 29 2022 - 13:49:15 EST


On Tue, Nov 29, 2022 at 04:12:10PM +0200, Vladimir Oltean wrote:
> dpaa2_eth_setup_dpni() is called from the probe path and
> dpaa2_eth_set_link_ksettings() is propagated to user space.
>
> include/linux/errno.h says that ENOTSUPP is "Defined for the NFSv3
> protocol". Conventional wisdom has it to not use it in networking
> drivers. Replace it with -EOPNOTSUPP.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew