Re: [Intel-wired-lan] [PATCH] igbvf: Regard vf reset nack as success

From: Akihiko Odaki
Date: Tue Nov 22 2022 - 10:29:08 EST


Hi,

On 2022/11/22 23:17, Paul Menzel wrote:
Dear Akihiko,


Thank you for your patch.


Am 22.11.22 um 10:27 schrieb Akihiko Odaki:
vf reset nack actually represents the reset operation itself is
performed but no address is not assigned. Therefore, e1000_reset_hw_vf

Is … no … not assigned … intentional?

should fill the "perm_addr" with the zero address and return success on
such an occassion. This prevents its callers in netdev.c from saying PF

occasion

I have just sent v2 with the message fixed.


still resetting, and instead allows them to correctly report that no
address is assigned.

In what environment do you hit the problem?

I found this bug when I was developing a QEMU patch to emulate 82576.

Regards,
Akihiko Odaki


[…]


Kind regards,

Paul