Re: [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig dependencies

From: Paul Gazzillo
Date: Thu Nov 10 2022 - 15:43:31 EST



On 11/10/2022, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 09:44:48AM -0500, Paul Gazzillo wrote:
>
> > CC drivers/iio/light/rpr0521.o
> > drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':
>
> These two lines can be removed.

Will do.

> > (This bug was found with the help of a tool, krepair, that generates
> > configuration files for commits: https://github.com/paulgazz/kmax)
>
> I'm not sure we need this in the commit message. Do we have a tag for
> the static analyzers?

I'll also remove this.

> > The following patch ensures that the code controlled by IIO_BUFFER and
> > IIO_TRIGGERED_BUFFER is available:
>
> > Reported-by: Paul Gazzillo <paul@xxxxxxxxx>
>
> Without SoB this may not be anyhow proceeded. Please, read Submitting Patches
> documentation and try again.
>
> (Btw, Reported-by above contradicts the commit message that refers to the tool,
> and not human)

Apologies, I was confused about whether I or the maintainer fills that
out. Will submit a new version with SoB.

Thanks!
Paul

>
> --
> With Best Regards,
> Andy Shevchenko