[PATCH 1/1] HID: Print specific timeout error in probe

From: Andreas Bergmeier
Date: Thu Nov 10 2022 - 15:42:40 EST


When -ETIMEOUT gets reported ensure that the error message mentiones
timeout.

Signed-off-by: Andreas Bergmeier <abergmeier@xxxxxxx>
---
drivers/hid/hid-logitech-hidpp.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 20ae7f73ef08..a0c148a8df6c 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4438,12 +4438,16 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id)
if (hidpp->quirks & HIDPP_QUIRK_UNIFYING)
hidpp_unifying_init(hidpp);

- connected = hidpp_root_get_protocol_version(hidpp) == 0;
+ ret = hidpp_root_get_protocol_version(hidpp);
+ connected = ret == 0;
atomic_set(&hidpp->connected, connected);
if (!(hidpp->quirks & HIDPP_QUIRK_UNIFYING)) {
if (!connected) {
+ if (ret == -ETIMEDOUT)
+ hid_err(hdev, "Device connection timed out");
+ else
+ hid_err(hdev, "Device not connected");
ret = -ENODEV;
- hid_err(hdev, "Device not connected");
goto hid_hw_init_fail;
}

--
2.34.1