Re: [PATCH v2 net-next 3/6] dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port reference

From: Rob Herring
Date: Fri Nov 04 2022 - 14:53:50 EST


On Thu, Nov 03, 2022 at 09:52:01PM -0700, Colin Foster wrote:
> dsa.yaml contains a reference to dsa-port.yaml, so a duplicate reference to
> the binding isn't necessary. Remove this unnecessary reference.
>
> Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>
> Suggested-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Reviewed-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> ---
>
> v1 -> v2
> * Add Reviewed-by
>
> ---
> Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index f2e9ff3f580b..81f291105660 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -159,8 +159,6 @@ patternProperties:
> type: object
> description: Ethernet switch ports
>
> - unevaluatedProperties: false
> -

You just allowed this node to have any property.

> properties:
> reg:
> description:
> @@ -168,7 +166,6 @@ patternProperties:
> for user ports.
>
> allOf:
> - - $ref: dsa-port.yaml#
> - if:
> required: [ ethernet ]
> then:
> --
> 2.25.1
>
>