Re: [PATCH v2] usb: dwc3: st: Rely on child's compatible instead of name

From: Greg Kroah-Hartman
Date: Fri Sep 30 2022 - 07:51:47 EST


On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@xxxxxxxxxxx wrote:
> From: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
>
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
>
> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
>
> Cc: Jerome Audu <jerome.audu@xxxxxx>
> Reported-by: Felipe Balbi <felipe@xxxxxxxx>
> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..fea5290de83f 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
> /* Manage SoftReset */
> reset_control_deassert(dwc3_data->rstc_rst);
>
> - child = of_get_child_by_name(node, "dwc3");
> + child = of_get_compatible_child(node, "snps,dwc3");
> if (!child) {
> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
> ret = -ENODEV;
> --
> 2.25.1
>

This commit doesn't even apply to my tree. What branch is it against?

confused,

greg k-h