Re: [PATCH v2 1/2] dt-bindings: clock: Add bindings for Renesas ProXO

[Michal Simek]

Hi Alex,

On 9/27/22 01:04, Rob Herring wrote:
> On Fri, Sep 23, 2022 at 01:52:50PM -0700, Alex Helms wrote:
> > Add dt bindings for the Renesas ProXO oscillator.
> >
> > Signed-off-by: Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/renesas,proxo.yaml         | 49 +++++++++++++++++++
> >   MAINTAINERS                                   |  5 ++
> >   2 files changed, 54 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> > new file mode 100644
> > index 000000000..79d62f399
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/renesas,proxo.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas ProXO Oscillator Device Tree Bindings
> > +
> > +maintainers:
> > +  - Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> > +
> > +description:
> > +  Renesas ProXO is a family of programmable ultra-low phase noise
> > +  quartz-based oscillators.
> > +
> > +properties:
> > +  '#clock-cells':
> > +    const: 0
> > +
> > +  compatible:
> > +    enum:
> > +      - renesas,proxo-xp
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  renesas,crystal-frequency:
> > +    description: Internal crystal frequency, default is 50000000 (50MHz)
> > +    $ref: /schemas/types.yaml#/definitions/uint32
>
> 'clock-frequency' doesn't work here?
>
> Anything else needs '-hz' suffix.


Driver is also using clock-output-names which is not listed here.

Thanks,
Michal