Re: [PATCH v2 1/2] dt-bindings: clock: Add bindings for Renesas ProXO

From: Rob Herring
Date: Mon Sep 26 2022 - 19:04:47 EST


On Fri, Sep 23, 2022 at 01:52:50PM -0700, Alex Helms wrote:
> Add dt bindings for the Renesas ProXO oscillator.
>
> Signed-off-by: Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> ---
> .../bindings/clock/renesas,proxo.yaml | 49 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> new file mode 100644
> index 000000000..79d62f399
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/renesas,proxo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas ProXO Oscillator Device Tree Bindings
> +
> +maintainers:
> + - Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> +
> +description:
> + Renesas ProXO is a family of programmable ultra-low phase noise
> + quartz-based oscillators.
> +
> +properties:
> + '#clock-cells':
> + const: 0
> +
> + compatible:
> + enum:
> + - renesas,proxo-xp
> +
> + reg:
> + maxItems: 1
> +
> + renesas,crystal-frequency:
> + description: Internal crystal frequency, default is 50000000 (50MHz)
> + $ref: /schemas/types.yaml#/definitions/uint32

'clock-frequency' doesn't work here?

Anything else needs '-hz' suffix.

> +
> +required:
> + - '#clock-cells'
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + proxo: clock-controller@55 {
> + compatible = "renesas,proxo-xp";
> + reg = <0x55>;
> + #clock-cells = <0>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 350102355..d52a8a5d2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16080,6 +16080,11 @@ S: Supported
> F: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> F: drivers/iio/adc/rzg2l_adc.c
>
> +RENESAS PROXO CLOCK DRIVER
> +M: Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> +S: Maintained
> +F: Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> +
> RESET CONTROLLER FRAMEWORK
> M: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> S: Maintained
> --
> 2.30.2
>
>